On 10/4/23 13:36, Ben Greear wrote:
On 10/4/23 12:38, Johannes Berg wrote:
On Tue, 2023-10-03 at 09:43 -0700, greearb@xxxxxxxxxxxxxxx wrote:
From: Ben Greear <greearb@xxxxxxxxxxxxxxx>
Check if user has configured STA to be AX mode, and if so,
skip the check for MLD elements (as they would not be needed
in AX mode).
Eh, no, I think this is wrong.
if (ieee80211_vif_is_mld(&sdata->vif)) {
If you get past this if, you've (locally) committed to doing EHT
already, not just HE (née 11ax), so should have an EHT connection?
Though the change is hard to read - but why are you telling the
supplicant to connect with MLO if you wanted to not use EHT?
It is mostly white-space changes, but the diff is ugly.
I caused the DISABLE_EHT flag to be set in mac80211, and that generally
seems to work in my kernel, but something is still trying to do MLO I guess.
I did not specifically tell supplicant to do MLO, and in fact I told
it to disable_be, but maybe that is not fully implemented. My supplicant
is a few months old vs upstream at this point.
I created a patch to supplicant where it will disable MLO if disable_eht
is true, and that seems to have properly associated a non-MLO station
in AX mode.
So I agree that my patch to the kernel is not needed.
Thanks for the patch review and comments.
Thanks,
Ben
