On 10/4/23 10:24, Kalle Valo wrote:
Aditya Kumar Singh <quic_adisi@xxxxxxxxxxx> writes:
On 10/3/23 20:01, Kalle Valo wrote:
Aditya Kumar Singh <quic_adisi@xxxxxxxxxxx> wrote:
Tx power is fetched from firmware's pdev stats. However, during active
CAC, firmware does not fill the current Tx power and sends the max
initialised value filled during firmware init. If host sends this power
to user space, this is wrong since in certain situations, the Tx power
could be greater than the max allowed by the regulatory. Hence, host
should not be fetching the Tx power during an active CAC.
Fix this issue by returning Tx power as 0 during active CAC since it
is known that during CAC, there will be no transmission happening.
The returning as 0 doesn't seem to match the code. Should I change
the sentence to:
"Fix this issue by returning -EAGAIN error so that the user space
knows there's
no value available right now."
Oops. Looks like only in commit message its still zero. Its changed to
return -EAGAIN in code.
+ if (test_bit(ATH11K_CAC_RUNNING, &ar->dev_flags)) {
+ mutex_unlock(&ar->conf_mutex);
+ return -EAGAIN;
+ }
So could you just rectify while applying or should I resend?
No need to resend because of this. I changed the commit message now to
this in the pending branch:
https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=6eacc3b5a70ab3f92f9410839870edbb21c9d051Sure, thanks!
