Baochen Qiang <quic_bqiang@xxxxxxxxxxx> wrote: > In ath11k_pci_probe() there is a switch statement that, based > upon the PCI device ID, assigns pci_ops. After the switch, > ath11k_pcic_register_pci_ops() is called to register the pci_ops. > > Unfortunately, this registration is too late if any of the cases > in the switch need to perform operations that require the pci_ops > to already be registered. In particular, an upcoming patch for > QCA2066 needs to call ath11k_pcic_read32(). > > To address this issue, call ath11k_pcic_register_pci_ops() from > each case instead of doing so after the switch. That way the ops > will be registered if any subsequent operations within the case > processing require the ops to be present. > > Tested-on: WCN6855 hw2.1 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3 > > Signed-off-by: Baochen Qiang <quic_bqiang@xxxxxxxxxxx> I'll now drop these from my queue, please resubmit as v2 once we have pushed the firmware to public. 2 patches set to Changes Requested. 13343062 [1/2] wifi: ath11k: move pci.ops registration ahead 13343063 [2/2] wifi: ath11k: add support for QCA2066 -- https://patchwork.kernel.org/project/linux-wireless/patch/20230807061749.9404-2-quic_bqiang@xxxxxxxxxxx/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
