On Tue, 2008-11-18 at 11:23 -0800, John W. Linville wrote:
> On Mon, Nov 17, 2008 at 11:48:19AM +0100, Frank Seidel wrote:
> > From: Zhu Yi <yi.zhu@xxxxxxxxx>
> >
> > Fixes Oops in ipw2200:ipw_tx_skb when pinging through
> > a WPA enterprise connection.
> >
> > Signed-off-by: Zhu Yi <yi.zhu@xxxxxxxxx>
> > Tested-by: Frank Seidel <fseidel@xxxxxxx>
> > Signed-off-by: Ffrank Seidel <fseidel@xxxxxxx>
> >
> > ---
> > drivers/net/wireless/ipw2200.c | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > --- a/drivers/net/wireless/ipw2200.c
> > +++ b/drivers/net/wireless/ipw2200.c
> > @@ -10190,6 +10190,11 @@ static int ipw_tx_skb(struct ipw_priv *p
> > u16 remaining_bytes;
> > int fc;
> >
> > + if (!(priv->status & STATUS_ASSOCIATED)) {
> > + IPW_DEBUG_TX("Tx attempt while not associated.\n");
> > + goto drop;
> > + }
> > +
> > hdr_len = ieee80211_get_hdrlen(le16_to_cpu(hdr->frame_ctl));
> > switch (priv->ieee->iw_mode) {
> > case IW_MODE_ADHOC:
> >
>
> Well, I'm sorry to be a PITA...but the changelog doesn't really
> explain how the patch works or what it is doing. Also, this still
> seems to me more like a band-aid than a real fix...?
John,
The commit message could be changed to:
"This patch fixes the ipw2200 kernel oops caused by sending frames
while not in associated state."
Will this be sufficient?
Reinette
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
