On 2023-09-25 08:03:09, Johannes Berg wrote:
> On Sun, 2023-09-24 at 22:43 -0400, Antoine Beaupré wrote:
[...]
>> > I think something like this, perhaps:
>> >
>> > --- a/drivers/net/wireless/intel/iwlwifi/mvm/scan.c
>> > +++ b/drivers/net/wireless/intel/iwlwifi/mvm/scan.c
>> > @@ -2342,7 +2342,7 @@ iwl_mvm_scan_umac_fill_general_p_v12(struct iwl_mvm *mvm,
>> > if (gen_flags & IWL_UMAC_SCAN_GEN_FLAGS_V2_FRAGMENTED_LMAC2)
>> > gp->num_of_fragments[SCAN_HB_LMAC_IDX] = IWL_SCAN_NUM_OF_FRAGS;
>> >
>> > - if (version < 12) {
>> > + if (version < 12 || !iwl_mvm_has_mld_api(mvm->fw)) {
>> > gp->scan_start_mac_or_link_id = scan_vif->id;
>> > } else {
>> > struct iwl_mvm_vif_link_info *link_info;
>>
>> Interesting! In any case, the firmware is certainly out of date in
>> Debian stable, and I guess it's to be expected that having it out of
>> sync with the running kernel is a Bad Idea, it's just not something I've
>> thought of before. :)
>
> Did that patch help?
I haven't tried, to be honest. It's been years since I compiled a
kernel, so I haven't actually seriously considered it. But I can
definitely put that on my list if it would be useful for you!
Quite a bit of scaffolding to build to get back down there though...
>> Thanks for the debugging, I'll make sure to keep the firmware and kernel
>> in better lockstep in the future!
>
> Yes, you can ... but I mean, we still do want to consider this a bug, I
> think, since we explicitly built the thing to load the older firmware.
> It just gets _far_ less testing.
Got it, happy to play guinea pig a little further if that's useful.
a.
--
The desire to sacrifice an entire lifetime to the noblest of ideals
serves no purpose if one works alone.
- Che Guevara
