On Fri, 2023-09-22 at 12:49 +0300, Kalle Valo wrote: > > > + if (iftd->types_mask & BIT(arvif->vif->type)) { > > Johannes pointed out that I should use ieee80211_get_he_iftype_cap_vif() > instead. I'll submit v2. And I'll note that it's not just because it saves open-coding it, also the BIT(vif->type) in mac80211 will be wrong because it's always STATION even for P2P-Client, so you need to add the vif->p2p bit in. We maybe shouldn't have done that ... but it seemed kinda nicer at the time to treat them both the same except in special cases. johannes