On 9/20/23 13:53, Wen Gong wrote:
+ if (ath11k_mac_supports_6ghz_cc_ext(ar) &&
+ ctx->def.chan->band == NL80211_BAND_6GHZ &&
+ arvif->vdev_type == WMI_VDEV_TYPE_STA) {
+ reg_info = &ab->reg_info_store[ar->pdev_idx];
+ power_type = vif->bss_conf.power_type;
+ ath11k_dbg(ab, ATH11K_DBG_MAC, "mac chanctx power type %d\n",
+ power_type);
+ if (power_type == IEEE80211_REG_UNSET_AP)
+ power_type = IEEE80211_REG_LPI_AP;
Why having _UNSET_ power type in vif->bss_conf.power_type is fine?
Typically, during association, we would be setting this from the
beacon/association response frame's HE 6 GHz Operation Info Field. So is
it fine if the field is carrying some info which we don't know (or may
be don't support it yet)? Why are we masking it with _LPI_ mode?
Also, I see that currently mac80211 only sets LPI or SP. So let's say
STA is trying to connect to VLP AP, mac80211 will set it as _UNSET_. And
then here, we will be treating it as LPI AP. Is that fine?
