On 9/20/23 16:23, Kalle Valo wrote:
I have on purpose avoided to use void functions in ath10k/ath11k/ath12k.
The problem is that if some of the functions return void and some of the
functions return int it's much harder to review the code.
I realize that you're constantly overloaded with reviewing a lot of patches...
If most/all of the functions return the same error value type as int > it makes a lot easier to read the code.
...but still not sure that this is reasonable for any non-trivial piece
of the source code.
OTOH if both you and Jeff are agreed on preserving existing ath1x style,
I will definitely take this decision into account and try to redesign
this series in attempt to fit the current design as much as possible.
Dmitry
