On 9/7/23 23:27, Johannes Berg wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On Thu, 2023-09-07 at 17:08 +0000, Prasurjya.Rohansaikia@xxxxxxxxxxxxx > wrote: >> From: Prasurjya Rohan Saikia <prasurjya.rohansaikia@xxxxxxxxxxxxx> >> >> Added an algorithm to backoff the Tx Task when low memory scenario is >> triggered at firmware. During high data transfer from host, the firmware >> runs out of VMM memory, which is used to hold the frames from the host. >> So added flow control to delay the transmit from host side when there is >> not enough space to accomodate frames in firmware side. >> > > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#commit_messages > > Please write commit messages, like mentioned for the subject above, > in imperative voice. > > and that says: > > Subject lines, like commit messages (see below) should be written in > imperative voice (“fix foo and optimize bar”), not in any other way such > as past tense (“fixed foo and optimized bar”). > > johannes Thanks you for pointing it out. I've accordingly updated my current outgoing patch & will definitely keep this point in mind the next time I create a commit.
