Search Linux Wireless

Re: [PATCH v2] rfkill: sync before userspace visibility/changes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Johannes,

kernel test robot noticed the following build warnings:

[auto build test WARNING on wireless-next/main]
[also build test WARNING on wireless/main linus/master v6.6-rc1 next-20230914]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Johannes-Berg/rfkill-sync-before-userspace-visibility-changes/20230914-221103
base:   https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git main
patch link:    https://lore.kernel.org/r/20230914153604.9d1ce0f43ac8.If977317d8f6a0f557090defcd6aef67628f62ff7%40changeid
patch subject: [PATCH v2] rfkill: sync before userspace visibility/changes
config: i386-buildonly-randconfig-003-20230915 (https://download.01.org/0day-ci/archive/20230915/202309150223.e6DfafFk-lkp@xxxxxxxxx/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230915/202309150223.e6DfafFk-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309150223.e6DfafFk-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

   net/rfkill/core.c: In function 'soft_show':
   net/rfkill/core.c:735:2: error: implicit declaration of function 'rfkill_sync'; did you mean 'rfkill_event'? [-Werror=implicit-function-declaration]
     735 |  rfkill_sync(rfkill);
         |  ^~~~~~~~~~~
         |  rfkill_event
   net/rfkill/core.c: At top level:
>> net/rfkill/core.c:1044:13: warning: conflicting types for 'rfkill_sync'
    1044 | static void rfkill_sync(struct rfkill *rfkill)
         |             ^~~~~~~~~~~
   net/rfkill/core.c:1044:13: error: static declaration of 'rfkill_sync' follows non-static declaration
   net/rfkill/core.c:735:2: note: previous implicit declaration of 'rfkill_sync' was here
     735 |  rfkill_sync(rfkill);
         |  ^~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +/rfkill_sync +1044 net/rfkill/core.c

  1043	
> 1044	static void rfkill_sync(struct rfkill *rfkill)
  1045	{
  1046		lockdep_assert_held(&rfkill_global_mutex);
  1047	
  1048		if (!rfkill->need_sync)
  1049			return;
  1050	
  1051		rfkill_set_block(rfkill, rfkill_global_states[rfkill->type].cur);
  1052		rfkill->need_sync = false;
  1053	}
  1054	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux