On Wed, 2023-03-15 at 18:58 +0530, Aditya Kumar Singh wrote: > @@ -8650,6 +8660,14 @@ static int parse_reg_rule(struct nlattr *tb[], > > reg_rule->flags = nla_get_u32(tb[NL80211_ATTR_REG_RULE_FLAGS]); > > + if (reg_rule->flags & NL80211_RRF_PSD) { > + if (!tb[NL80211_ATTR_POWER_RULE_PSD]) > + return -EINVAL; > + > + reg_rule->psd = > + nla_get_s8(tb[NL80211_ATTR_POWER_RULE_PSD]); > + } Wait ... I'm not sure why we've been adding stuff to this recently, but anyway, this part should only be used by CRDA which is deprecated anyway? So I'd say we shouldn't touch any of the code under #ifdef CONFIG_CFG80211_CRDA_SUPPORT any more since CRDA will not continue to developed with any updates here. johannes