Juerg Haefliger <juerg.haefliger@xxxxxxxxxxxxx> writes: > On Wed, 13 Sep 2023 11:58:07 +0300 > Kalle Valo <kvalo@xxxxxxxxxx> wrote: > >> Juerg Haefliger <juerg.haefliger@xxxxxxxxxxxxx> writes: >> >> > Since commit 2d47c6956ab3 ("ubsan: Tighten UBSAN_BOUNDS on GCC"), >> > UBSAN_BOUNDS no longer pretends 1-element arrays are unbounded. Walking >> > 'element' and 'channel_list' will trigger warnings, so make them proper >> > flexible arrays. >> > >> > False positive warnings were: >> > >> > UBSAN: array-index-out-of-bounds in drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:6984:20 >> > index 1 is out of range for type '__le32 [1]' >> > >> > UBSAN: array-index-out-of-bounds in drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:1126:27 >> > index 1 is out of range for type '__le16 [1]' >> > >> > for these lines of code: >> > >> > 6884 ch.chspec = (u16)le32_to_cpu(list->element[i]); >> > >> > 1126 params_le->channel_list[i] = cpu_to_le16(chanspec); >> > >> > Signed-off-by: Juerg Haefliger <juerg.haefliger@xxxxxxxxxxxxx> >> >> Should this be queued for v6.6? > > I would think so. It's a problem since 6.5. Which reminds me that I should > have added: > > Cc: stable@xxxxxxxxxxxxxxx # 6.5+ I can add that during commit. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches