Search Linux Wireless

Re: [PATCH v6 2/3] wifi: mac80211: allow userspace to enable driver control of MU-EDCA

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> 
> --- a/include/net/mac80211.h
> +++ b/include/net/mac80211.h
> @@ -376,6 +376,7 @@ enum ieee80211_bss_change {
>  	BSS_CHANGED_FILS_DISCOVERY      = 1<<30,
>  	BSS_CHANGED_UNSOL_BCAST_PROBE_RESP = 1<<31,
>  	BSS_CHANGED_EHT_PUNCTURING	= BIT_ULL(32),
> +	BSS_CHANGED_DYNAMIC_MU_EDCA	= BIT_ULL(33),

This is missing documentation.

> + * @dyn_muedca_enabled: whether to enable or disable driver control of MU-EDCA
> + *	parameters. If set to zero, driver dynamically updating parameters is
> + *	disabled; if set to 1, driver dynamically updating parameters is enable
>   */
>  struct ieee80211_bss_conf {
>  	struct ieee80211_vif *vif;
> @@ -776,6 +780,8 @@ struct ieee80211_bss_conf {
>  	bool eht_su_beamformer;
>  	bool eht_su_beamformee;
>  	bool eht_mu_beamformer;
> +
> +	int dyn_muedca_enabled;

why int with 0/1 rather than bool like the others?

> @@ -1465,6 +1465,11 @@ static int ieee80211_start_ap(struct wiphy *wiphy, struct net_device *dev,
>  		changed |= BSS_CHANGED_UNSOL_BCAST_PROBE_RESP;
>  	}
>  
> +	if (link_conf->dyn_muedca_enabled != params->dyn_muedca_enable) {
> +		link_conf->dyn_muedca_enabled = params->dyn_muedca_enable;
> +		changed |= BSS_CHANGED_DYNAMIC_MU_EDCA;
> +	}

This doesn't seem right ... think about it.

johannes




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux