On Tue, 2023-09-12 at 12:24 +0530, Vinayak Yadawad wrote: > In 4way handshake offload, cfg80211_port_authorized > enables driver to indicate successful 4way handshake to cfg80211 layer. > Currently this path of port authorization is restricted to > interface type NL80211_IFTYPE_STATION and NL80211_IFTYPE_P2P_CLIENT. > This patch extends the support for NL80211_IFTYPE_AP and > NL80211_IFTYPE_P2P_GO interfaces to authorize peer STA/P2P_CLIENT, > whenever authentication is offloaded on the AP/P2P_GO interface. It seems that this should at least also come with documentation updates in nl80211.h? And proper code indentation :-) > - * @bssid: the BSSID of the AP > + * @peer_mac: BSSID of the AP/P2P GO in case of STA/GC or STA/GC macaddress in > + * case of AP/P2P GO And "peer_addr" is probably better? Technically, after all, it's the "MAC address" (which you also spelled wrong), but the "MAC" itself :) johannes