On Fri, Sep 08, 2023 at 12:23:13AM +0000, Ping-Ke Shih wrote: > > > > -----Original Message----- > > From: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> > > Sent: Thursday, September 7, 2023 3:16 PM > > To: linux-wireless@xxxxxxxxxxxxxxx > > Cc: linux-kernel@xxxxxxxxxxxxxxx; Kalle Valo <kvalo@xxxxxxxxxx>; Ping-Ke Shih <pkshih@xxxxxxxxxxx>; Yanik > > Fuchs <Yanik.fuchs@xxxxxx> > > Subject: [PATCH] wifi: rtw88: rtw8723d: Fix MAC address offset in EEPROM > > > > The MAC address is stored at offset 0x107 in the EEPROM, like correctly > > stated in the comment. Add a two bytes reserved field right before the > > MAC address to shift it from offset 0x105 to 0x107. > > > > With this the MAC address returned from my RTL8723du wifi stick can be > > correctly decoded as "Shenzhen Four Seas Global Link Network Technology > > Co., Ltd." > > With this correctness, my stick can be recognized as: > " Bus 003 Device 010: ID 0bda:d723 Realtek Semiconductor Corp. 802.11n WLAN Adapter" It should be recognized like this also without this patch, but with this patch the MAC address should be read correctly. > > Should it add a Fixes tag? > Fixes: 87caeef032fc ("wifi: rtw88: Add rtw8723du chipset support") Yes, I forgot this. Kalle, can you add it once again while applying? Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |