Rand Deeb <rand.sec96@xxxxxxxxx> wrote: > In ssb_calc_clock_rate(), there is a potential issue where the value of > m1 could be zero due to initialization using clkfactor_f6_resolv(). This > situation raised concerns about the possibility of a division by zero > error. > > We fixed it by following the suggestions provided by Larry Finger > <Larry.Finger@xxxxxxxxxxxx> and Michael Büsch <m@xxxxxxx>. The fix > involves returning a value of 1 instead of 0 in clkfactor_f6_resolv(). > This modification ensures the proper functioning of the code and > eliminates the risk of division by zero errors. > > Signed-off-by: Rand Deeb <rand.sec96@xxxxxxxxx> > Acked-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx> > Acked-by: Michael Büsch <m@xxxxxxx> Patch applied to wireless-next.git, thanks. e0b5127fa134 ssb: Fix division by zero issue in ssb_calc_clock_rate -- https://patchwork.kernel.org/project/linux-wireless/patch/20230904232346.34991-1-rand.sec96@xxxxxxxxx/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches