On 30/08/2023 10:27, Rand Deeb wrote: > In ssb_calc_clock_rate(), the value of m1 may be zero because it is > initialized using clkfactor_f6_resolv(). This function could return > zero, so there is a possibility of dividing by zero, we fixed it by > checking the values before dividing. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. Version your patches and provide changelog after --- . > > Signed-off-by: Rand Deeb <deeb.rand@xxxxxxxxxxxx> > --- > drivers/ssb/main.c | 16 ++++++++++++---- > 1 file changed, 12 insertions(+), 4 deletions(-) > > diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c > index 0a26984acb2c..e0776a16d04d 100644 > --- a/drivers/ssb/main.c > +++ b/drivers/ssb/main.c > @@ -903,13 +903,21 @@ u32 ssb_calc_clock_rate(u32 plltype, u32 n, u32 m) > case SSB_CHIPCO_CLK_MC_BYPASS: > return clock; > case SSB_CHIPCO_CLK_MC_M1: > - return (clock / m1); > + if (m1 !=3D 0) Nothing improved here. Don't send patches as quoted-printable via some weird mailers. Recommendation is to use standard tool - git send-email. As you can easily see on the web - it is re-formatted for quoted-printable: https://lore.kernel.org/all/20230830082759.23336-1-deeb.rand@xxxxxxxxxxxx/raw Best regards, Krzysztof
