On Sat, 26 Aug 2023 at 08:44, Kalle Valo <kvalo@xxxxxxxxxx> wrote: > > Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> writes: > > > Default to 'board.bin' for the legacy board data file, in case the > > hw_params array doesn't list hw-specific board data file name (e.g. for > > WCN3990). > > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > > Could you provide more background _why_ this is needed. What are you > trying to fix? Sure. For wcn3990 we do not have the `ath10k_hw_params_list[].fw.board' set. So if the board data is not present in `board-2.bin', the driver will skip looking into `board.bin' and will error out. I had two options: either to set the `.fw.board' in `ath10k_hw_params_list', or to provide this default. Granted that the check for `fw.board' also prevents the `board-%s-%s.bin' lookup, I opted for the second option. Maybe I should just set the .fw.board to "board.bin" and .fw.board_size to 26328 (?) -- With best wishes Dmitry
