Search Linux Wireless

Re: [PATCH] wifi: mwifiex: cleanup struct mwifiex_sdio_mpa_rx

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 21, 2023 at 02:52:50PM +0300, Dmitry Antipov wrote:
> Drop filled with NULL pointers but otherwise unused 'skb_arr'
> array of 'struct mwifiex_sdio_mpa_rx', adjust related code.
> 
> Fixes: 960d6d08e395 ("mwifiex: delay skb allocation for RX until cmd53 over")

This is not the appropriate Fixes line. These fields continued to be
used afterward, so it would be actively harmful to tell people (or bots)
to backport this patch that far.

I'm not even going to tell you what the last commit that used it was,
because that would still just be nonsense. It's better to have no Fixes
line than to conjure up a garbage one, especially for something for
trivial.

> Signed-off-by: Dmitry Antipov <dmantipov@xxxxxxxxx>

The contents look good though:

Acked-by: Brian Norris <briannorris@xxxxxxxxxxxx>



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux