Ping-Ke Shih <pkshih@xxxxxxxxxxx> wrote: > There are two copies of MAC hardware called band0 and band1. Basically, > the only difference between them is base address, so we can share functions > with a 'band' (or 'mac_idx') argument. > > The offset of base address of WiFi 6 and 7 are 0x2000 and 0x4000 > respectively, so add band1_offset field to new introduced struct > mac_gen_def to possibly reuse functions. > > Using below spatch script to convert callers: > > @@ > expression reg, band; > @@ > - rtw89_mac_reg_by_idx(reg, band) > + rtw89_mac_reg_by_idx(rtwdev, reg, band) > > @@ > expression reg, port, band; > @@ > - rtw89_mac_reg_by_port(reg, port, band) > + rtw89_mac_reg_by_port(rtwdev, reg, port, band) > > Signed-off-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx> 6 patches applied to wireless-next.git, thanks. c220d08e1f98 wifi: rtw89: mac: add mac_gen_def::band1_offset to map MAC band1 register address 60168f6c50ed wifi: rtw89: mac: generalize code to indirectly access WiFi internal memory 3a7e4f56eb18 wifi: rtw89: mac: define internal memory address for WiFi 7 chip 9d87e7dc930e wifi: rtw89: mac: define register address of rx_filter to generalize code 1165f5719229 wifi: rtw89: phy: add phy_gen_def::cr_base to support WiFi 7 chips 058b20748197 wifi: rtw89: phy: modify register setting of ENV_MNTR, PHYSTS and DIG -- https://patchwork.kernel.org/project/linux-wireless/patch/20230822125822.23817-2-pkshih@xxxxxxxxxxx/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches