On Wed, Aug 23, 2023 at 3:25 AM Kalle Valo <kvalo@xxxxxxxxxx> wrote:
>
> Dmitry Antipov <dmantipov@xxxxxxxxx> wrote:
>
> > Simplify PCIE DMA mapping management by eliminating extra copies
> > of {address, size} pairs to/from temporary data structures. Map
> > and unmap operations may use skb fields directly via introduced
> > 'MWIFIEX_SKB_DMA_ADDR()' and 'MWIFIEX_SKB_DMA_SIZE()' macros.
> >
> > Signed-off-by: Dmitry Antipov <dmantipov@xxxxxxxxx>
>
> I assume these patches are compile tested only so I'm very reluctant
> take these.
>
> 2 patches set to Changes Requested.
That's fair IMO. These kinds of patches put a much larger burden on
the reviewer to make sure they make sense. Thus, I had this in a
backlog to review, and haven't gotten around to it.
If Dmitry can prove out some proper testing, maybe the status can
change [1]. Or maybe I'll feel charitable and look/test them more
closely.
Brian
[1] Although, I don't think I have permission to change the Patchwork
status, so it still might be lost to /dev/null without a RESEND.
