On Wed, 2023-08-23 at 10:28 +0800, Wen Gong wrote: > > > > /* need to have local link addresses for MLO connections */ > > > > WARN_ON(cr.ap_mld_addr && !cr.links[link_id].addr); > > > > makes no sense anymore. Not sure if that's the only one. > > After this patch, the cr.links[link_id].addr will be a valid local link > address from > > struct cfg80211_rx_assoc_resp, so I think it is not needed remove now. You don't understand. The issue is that it's set the line above. > cr.links[link_id].addr = data->links[link_id].addr; > /* need to have local link addresses for MLO connections */ > WARN_ON(cr.ap_mld_addr && !cr.links[link_id].addr); But look at that! What values can cr.links[link_id].addr get? Note how it's a pointer - assigned from an array. johannes
