On 2023/8/16 22:31, Jeff Johnson wrote:
> On 8/16/2023 6:05 AM, Yue Haibing wrote:
>> Commit d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices")
>> declared but never implemented these, remove it.
>
> Note that the ath12k driver is under active development, and due to the manner in which this driver was originally upstreamed (staring with just core functionality) it is very possible that prototypes are present in the current upstream code that are not currently being used, but which will be used in the future.
>
> However, since there are currently no implementations, it seems logical to remove them for now. They can always be added back when the implementations are provided.
>
> And for four of these ath11k also has unused prototypes, so feel free to submit a patch for those.
Thanks, this is done in https://patchwork.kernel.org/project/linux-wireless/patch/20230811104413.33668-1-yuehaibing@xxxxxxxxxx
>
> Further details below
>
>>
>> Signed-off-by: Yue Haibing <yuehaibing@xxxxxxxxxx>
>
> Acked-by: Jeff Johnson <quic_jjohnson@xxxxxxxxxxx>
>
>> ---
>> drivers/net/wireless/ath/ath12k/ce.h | 3 ---
>> drivers/net/wireless/ath/ath12k/core.h | 1 -
>> drivers/net/wireless/ath/ath12k/qmi.h | 2 --
>> drivers/net/wireless/ath/ath12k/wmi.h | 2 --
>> 4 files changed, 8 deletions(-)
>
>
>>
>> diff --git a/drivers/net/wireless/ath/ath12k/ce.h b/drivers/net/wireless/ath/ath12k/ce.h
>> index 17cf16235e0b..79af3b6159f1 100644
>> --- a/drivers/net/wireless/ath/ath12k/ce.h
>> +++ b/drivers/net/wireless/ath/ath12k/ce.h
>> @@ -176,9 +176,6 @@ int ath12k_ce_alloc_pipes(struct ath12k_base *ab);
>> void ath12k_ce_free_pipes(struct ath12k_base *ab);
>> int ath12k_ce_get_attr_flags(struct ath12k_base *ab, int ce_id);
>> void ath12k_ce_poll_send_completed(struct ath12k_base *ab, u8 pipe_id);
>> -int ath12k_ce_map_service_to_pipe(struct ath12k_base *ab, u16 service_id,
>> - u8 *ul_pipe, u8 *dl_pipe);
>> -int ath12k_ce_attr_attach(struct ath12k_base *ab);
>
> These were inherited from ath11k, and are unused there as well. These can go. Also feel free to submit a similar patch for ath11k
>
>> void ath12k_ce_get_shadow_config(struct ath12k_base *ab,
>> u32 **shadow_cfg, u32 *shadow_cfg_len);
>> #endif
>> diff --git a/drivers/net/wireless/ath/ath12k/core.h b/drivers/net/wireless/ath/ath12k/core.h
>> index 4389ff40b49d..d873b573dac6 100644
>> --- a/drivers/net/wireless/ath/ath12k/core.h
>> +++ b/drivers/net/wireless/ath/ath12k/core.h
>> @@ -788,7 +788,6 @@ int ath12k_core_fetch_board_data_api_1(struct ath12k_base *ab,
>> int ath12k_core_fetch_bdf(struct ath12k_base *ath12k,
>> struct ath12k_board_data *bd);
>> void ath12k_core_free_bdf(struct ath12k_base *ab, struct ath12k_board_data *bd);
>> -int ath12k_core_check_dt(struct ath12k_base *ath12k);
>
> This was inherited from ath11k, and it is in use there.
> I'm not sure if the underlying functionality will be required on ath12k, but if so, the prototype can be added back when the function implementation is added. So this can be removed
>
>> void ath12k_core_halt(struct ath12k *ar);
>> int ath12k_core_resume(struct ath12k_base *ab);
>> diff --git a/drivers/net/wireless/ath/ath12k/qmi.h b/drivers/net/wireless/ath/ath12k/qmi.h
>> index df76149c49f5..15944f5f33ab 100644
>> --- a/drivers/net/wireless/ath/ath12k/qmi.h
>> +++ b/drivers/net/wireless/ath/ath12k/qmi.h
>> @@ -562,8 +562,6 @@ struct qmi_wlanfw_wlan_cfg_resp_msg_v01 {
>> int ath12k_qmi_firmware_start(struct ath12k_base *ab,
>> u32 mode);
>> void ath12k_qmi_firmware_stop(struct ath12k_base *ab);
>> -void ath12k_qmi_event_work(struct work_struct *work);
>> -void ath12k_qmi_msg_recv_work(struct work_struct *work);
>
> These were inherited from ath11k, and are unused there as well. These can go. Also feel free to submit a similar patch for ath11k
>
>> void ath12k_qmi_deinit_service(struct ath12k_base *ab);
>> int ath12k_qmi_init_service(struct ath12k_base *ab);
>> diff --git a/drivers/net/wireless/ath/ath12k/wmi.h b/drivers/net/wireless/ath/ath12k/wmi.h
>> index 8c047a9623f9..c75a6fa1f7e0 100644
>> --- a/drivers/net/wireless/ath/ath12k/wmi.h
>> +++ b/drivers/net/wireless/ath/ath12k/wmi.h
>> @@ -4855,8 +4855,6 @@ int ath12k_wmi_vdev_install_key(struct ath12k *ar,
>> struct wmi_vdev_install_key_arg *arg);
>> int ath12k_wmi_pdev_bss_chan_info_request(struct ath12k *ar,
>> enum wmi_bss_chan_info_req_type type);
>> -int ath12k_wmi_send_stats_request_cmd(struct ath12k *ar, u32 stats_id,
>> - u32 vdev_id, u32 pdev_id);
>
> This was inherited from ath11k, and it is in use there.
> I expect this API will be implemented in the future since it is used by the DebugFS code which is not yet present. That said, the prototype can be added back when the function implementation is added. So this can be removed
>
>
>> int ath12k_wmi_send_pdev_temperature_cmd(struct ath12k *ar);
>> int ath12k_wmi_send_peer_flush_tids_cmd(struct ath12k *ar,
>> u8 peer_addr[ETH_ALEN],
>
> .
