On Fri, Nov 14, 2008 at 10:13 AM, Sujith <m.sujith@xxxxxxxxx> wrote: > Luis R. Rodriguez wrote: >> On Fri, Nov 14, 2008 at 9:49 AM, Bob Copeland <me@xxxxxxxxxxxxxxx> wrote: >> > On Fri, Nov 14, 2008 at 12:37 PM, Luis R. Rodriguez <mcgrof@xxxxxxxxx> wrote: >> >> Anyway we do set the parent before calling ieee80211_register_hw() by >> >> using SET_IEEE80211_DEV(hw, &pdev->dev) (oh ok here is the parent). so >> >> when we try to get the name with parent->driver I am not sure if >> >> driver has been set yet because ath5k_pci_probe() hasn't finished yet >> >> as probe called ath5k_hw_attach(). When does ->driver get set and why >> >> would it fail only for ath5k? >> > >> > Ahh, I believe that would be in pci-driver.c __pci_device_probe, after driver >> > probe is run successfully. Yes, we do ieee80211_register_hw from within >> > probe... So, how did this ever work again? /me scratches head. >> >> Wow.. ok, yeah I see that, this is a mac8021 bug then unless mac80211 >> wants us to not callieee80211_register_hw() from probe or its children >> which would be weird. > > From the original log: > ath5k_pci 0000:01:00.0: registered as '' That comes from dev_info(&pdev->dev, "registered as '%s'\n", wiphy_name(hw->wiphy)); which means that may be buggy too as wiphy_name() gets return wiphy->dev.bus_id; and we only have set at that point wiphy->dev.parent IIRC. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
