On Fri, Aug 11, 2023 at 02:13:43AM +0000, David Lin wrote: > > From: Francesco Dolcini <francesco@xxxxxxxxxx> > > Sent: Thursday, August 10, 2023 10:25 PM > > To: David Lin <yu-hao.lin@xxxxxxx> > > Cc: Francesco Dolcini <francesco@xxxxxxxxxx>; linux-wireless@xxxxxxxxxxxxxxx; > > Sharvari Harisangam <sharvari.harisangam@xxxxxxx>; Pete Hsieh > > <tsung-hsien.hsieh@xxxxxxx> > > Subject: Re: [EXT] Re: [PATCH v3] wifi: mwifiex: added code to support host > > mlme. > > > > Caution: This is an external email. Please take care when clicking links or > > opening attachments. When in doubt, report the message using the 'Report > > this email' button > > > > > > On Thu, Aug 10, 2023 at 10:51:36AM +0000, David Lin wrote: > > > > From: Francesco Dolcini <francesco@xxxxxxxxxx> On Thu, Aug 10, 2023 > > > > at 02:39:21AM +0000, David Lin wrote: > > > > > 3. Firmware version 2 is needed for this feature. > > > > That would mean that we could just enable it for other Wi-Fi chip > > > > variant that has firmware version 2, after testing it? > > > Yes. But I only tested with IW416. > > > > Can/should we probe the firmware version at runtime, instead of hard-coding > > this? > > Firmware version is reported by firmware after firmware is downloaded. What's the problem with that? You cannot really do anything till the firmware is loaded? If I understand correctly the possibility to use this feature requires its counterpart to be available on the device firmware, this should be the criteria to use to decide if this functionality should be enabled or not. Hard-coding this depending on the actual device does not look correct to me. Francesco
