On 8/9/2023 9:31 PM, Wen Gong wrote:
On 8/10/2023 2:16 AM, Jeff Johnson wrote:
On 8/9/2023 10:31 AM, Jeff Johnson wrote:
On 8/9/2023 1:12 AM, Wen Gong wrote:
[...]
Reviewed-by: Jeff Johnson <quic_jjohnson@xxxxxxxxxxx>
Wen, can you please add a Fixes: tag since based upon the discussion
you actually observed a crash
Jeff, do you mean I should add the crash call stack or other thing in
this patch?
The crash is observed by Sven Eckelmann <sven@xxxxxxxxxxxxx> on 07 Dec
2021 here:
Subject: Re: [PATCH] ath11k: enable
IEEE80211_HW_SINGLE_SCAN_ON_ALL_BANDS for WCN6855
https://lore.kernel.org/linux-wireless/3267805.el9kkjlfUZ@ripper/
It isn't necessary to add a call stack. Based upon the above you should
add both a Fixes: tag and a Link: tag. These go in the tags section of
the commit text before the Signed-off-by:
<https://www.kernel.org/doc/html/latest/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes>
A Fixes: tag indicates that the patch fixes an issue in a previous
commit. It is used to make it easy to determine where a bug originated,
which can help review a bug fix. This tag also assists the stable kernel
team in determining which stable kernel versions should receive your
fix. This is the preferred method for indicating a bug fixed by the
patch. See Describe your changes for more details.
<https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-changes>
If related discussions or any other background information behind the
change can be found on the web, add 'Link:' tags pointing to it. If the
patch is a result of some earlier mailing list discussions or something
documented on the web, point to it.
