On 6/14/23 13:08, Johannes Berg wrote:
On Wed, 2023-06-14 at 09:39 -0700, Ben Greear wrote:
On 6/14/23 01:29, Johannes Berg wrote:
+ /* TODO: Fix and re-add this. It compiles in 6.4 but not against 'next'
+ * according to the kernel build bot.
+ * PFLAG(PHY, 5, SUPP_EXTRA_EHT_LTF, "SUPP-EXTRA-EHT-LTF");
+ */
Well that's because the spec version was updated in wireless-next :)
So please adjust according to the new fields there.
It will be some time before I get a chance to revisit this. If you can
accept as is, I'll fix the remaining bits when I move to 6.5 or whatever
mainline kernel has the updated spec.
Actually I think it was just this field, so maybe I can just take v1.
After doing some more detailed testing, I notice that this capa logic is using
the AP's capability list, and is not showing lowest common features. For instance,
a 2x2 STA radio shows as this when connected to 4x4 AP:
...
EHT bw <= 80 MHz, max NSS for MCS 8-9: Rx=4, Tx=4
EHT bw <= 80 MHz, max NSS for MCS 10-11: Rx=4, Tx=4
EHT bw <= 80 MHz, max NSS for MCS 12-13: Rx=4, Tx=4
EHT bw <= 160 MHz, max NSS for MCS 8-9: Rx=4, Tx=4
EHT bw <= 160 MHz, max NSS for MCS 10-11: Rx=4, Tx=4
EHT bw <= 160 MHz, max NSS for MCS 12-13: Rx=4, Tx=4
EHT bw <= 320 MHz, max NSS for MCS 8-9: Rx=4, Tx=4
EHT bw <= 320 MHz, max NSS for MCS 10-11: Rx=4, Tx=4
EHT bw <= 320 MHz, max NSS for MCS 12-13: Rx=4, Tx=4
I would expect it to show Rx=2, Tx=2 in this case.
Any opinions on how or whether to change this? Do we already store a combined
capabilities list somewhere in mac80211 for EHT?
Thanks,
Ben
--
Ben Greear <greearb@xxxxxxxxxxxxxxx>
Candela Technologies Inc http://www.candelatech.com
