On 8/8/2023 6:55 PM, Johannes Berg wrote:
Hi, Since I'm covering for Kalle right now ... On Sun, 2023-08-06 at 23:08 -0400, Wen Gong wrote:
[...]
I feel these are two separate issues. Having a large enough TLV that the firmware cannot parse it is highly unlikely to happen, and not really an issue here. Please split this into two patches, and fix *just* the buffer overflow in a patch titled "Fix buffer overflow". I believe simply changing the variable type is sufficient for this, as the code is otherwise equivalent. That's a patch I'd take to wireless at this stage (rc5), but probably not the entire bigger change. johannes
Yes, let me send the 2 patch separately .
