On 8/3/2023 7:32 PM, Kalle Valo wrote:
Wen Gong <quic_wgong@xxxxxxxxxxx> writes:
On 8/3/2023 5:24 PM, Kalle Valo wrote:
Wen Gong <quic_wgong@xxxxxxxxxxx> wrote:
RDDM is RAM DUMP DEBUG module, it is used to debug issues when firmware
encounters an error.
The rddm_size is needed by firmware while MHI enter RDDM state. Add it
to support device recovery when ath12k receive MHI_CB_EE_RDDM message.
Tested-on: WCN7850 hw2.0 PCI
WLAN.HMT.1.0-03427-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.15378.4
Signed-off-by: Wen Gong <quic_wgong@xxxxxxxxxxx>
Signed-off-by: Kalle Valo <quic_kvalo@xxxxxxxxxxx>
I'm not sure what "support device recovery" means exactly. How does this patch
change functionality from user's point of view?
No need to resend because of this, I can add that to the commit log.
Device recovery means SSR(subsystem restart), when firmware happen
crash, ath12k
will receive the RDDM event, and then ath12k/mac80211 begin to
re-start wifi/firmware,
after that, the wifi become normal again.
This patch is to let firmware report RDDM event correctly to ath12k.
Without this patch,
firmware will not report RDDM event to ath12k correctly, then ath12k
will not begin SSR
process.
I think it should be changed like this:
The rddm_size is needed by firmware while MHI enter RDDM state. Add it
and then firmware will report MHI_CB_EE_RDDM correctly while firmware
encounters an error, then ath12k could start the device recovery process.
How about this:
"RDDM is Ram Dump Debug Module which is used to debug issues when the
firmware encounters an error. The rddm_size is needed by the firmware
while MHI goes to the RDDM state. Provide the size to MHI subsystem so
that the firmware restart works when the firmware crashes."
Thanks.
Yes, it is OK for me.
