> -----Original Message----- > From: Ruan Jinjie <ruanjinjie@xxxxxxxxxx> > Sent: Friday, August 4, 2023 11:54 AM > To: sgoutham@xxxxxxxxxxx; davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx; kuba@xxxxxxxxxx; pabeni@xxxxxxxxxx; > jesse.brandeburg@xxxxxxxxx; anthony.l.nguyen@xxxxxxxxx; tariqt@xxxxxxxxxx; s.shtylyov@xxxxxx; > aspriel@xxxxxxxxx; franky.lin@xxxxxxxxxxxx; hante.meuleman@xxxxxxxxxxxx; kvalo@xxxxxxxxxx; > richardcochran@xxxxxxxxx; yoshihiro.shimoda.uh@xxxxxxxxxxx; ruanjinjie@xxxxxxxxxx; > u.kleine-koenig@xxxxxxxxxxxxxx; mkl@xxxxxxxxxxxxxx; lee@xxxxxxxxxx; set_pte_at@xxxxxxxxxxx; > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; intel-wired-lan@xxxxxxxxxxxxxxxx; > linux-rdma@xxxxxxxxxxxxxxx; linux-renesas-soc@xxxxxxxxxxxxxxx; linux-wireless@xxxxxxxxxxxxxxx; > brcm80211-dev-list.pdl@xxxxxxxxxxxx; SHA-cyfmac-dev-list@xxxxxxxxxxxx > Subject: [PATCH -next 3/6] net/mlx4: Remove an unnecessary ternary operator > > There is a ternary operator, the true or false judgement > of which is unnecessary in C language semantics. > > Signed-off-by: Ruan Jinjie <ruanjinjie@xxxxxxxxxx> > --- > drivers/net/ethernet/mellanox/mlx4/port.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/mellanox/mlx4/port.c b/drivers/net/ethernet/mellanox/mlx4/port.c > index 256a06b3c096..1c289488d050 100644 > --- a/drivers/net/ethernet/mellanox/mlx4/port.c > +++ b/drivers/net/ethernet/mellanox/mlx4/port.c > @@ -176,7 +176,7 @@ static bool mlx4_need_mf_bond(struct mlx4_dev *dev) > mlx4_foreach_port(i, dev, MLX4_PORT_TYPE_ETH) > ++num_eth_ports; > > - return (num_eth_ports == 2) ? true : false; > + return num_eth_ports == 2; It should be one space between '=' and '2'. > } > > int __mlx4_register_mac(struct mlx4_dev *dev, u8 port, u64 mac) > -- > 2.34.1 > > > ------Please consider the environment before printing this e-mail.
