Kees Cook <keescook@xxxxxxxxxxxx> writes: > On Wed, Aug 02, 2023 at 01:23:06AM +0000, Justin Stitt wrote: >> The current implementation seems to reinvent what `kstrtoul` already does >> in terms of functionality and error handling. Remove uses of `simple_strtoul()` >> in favor of `kstrtoul()`. >> >> There is the following note at `lib/vsprintf.c:simple_strtoull()` which >> further backs this change: >> | * This function has caveats. Please use kstrtoull (or kstrtoul) instead. >> >> And here, simple_str* are explicitly deprecated [3]. >> >> This patch also removes an instance of the deprecated `strncpy` which helps [2]. >> >> Link: https://lore.kernel.org/all/202308011602.3CC1C0244C@keescook/ [1] >> Link: https://github.com/KSPP/linux/issues/90 [2] >> Link: >> https://docs.kernel.org/process/deprecated.html#simple-strtol-simple-strtoll-simple-strtoul-simple-strtoull >> [3] >> Cc: linux-hardening@xxxxxxxxxxxxxxx >> Suggested-by: Kees Cook <keescook@xxxxxxxxxxxx> >> Signed-off-by: Justin Stitt <justinstitt@xxxxxxxxxx> > > This looks correct to me. I would be curious to hear back from the intel > folks if the interface continues to work correctly with real hardware. > > Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx> This is ancient hardware, not sure if anyone even have a working setup. And even if they would have one I doubt anyone uses this sysfs interface for anything. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
