Wen Gong <quic_wgong@xxxxxxxxxxx> wrote: > Currently ath12k define WMI_HOST_HW_MODE_DBS_OR_SBS=5 as max hw mode > for enum wmi_host_hw_mode_config_type, it is also same for the array > ath12k_hw_mode_pri_map. > > When tested with new version firmware/board data which support new > hw mode eMLSR mode with hw mode value 8, it leads overflow usage for > array ath12k_hw_mode_pri_map in function ath12k_wmi_hw_mode_caps(), > and then lead preferred_hw_mode changed to 8, and finally function > ath12k_pull_mac_phy_cap_svc_ready_ext() select the capability of hw > mode 8, but the capability of eMLSR mode report from firmware does > not support 2.4 GHz band for WCN7850, so finally 2.4 GHz band is > disabled. > > Skip the hw mode which exceeds WMI_HOST_HW_MODE_MAX in function > ath12k_wmi_hw_mode_caps() helps to avoid array overflow, then the 2.4 > GHz band will not be disabled. > > This is to keep compatibility with newer version firmware/board data > files, this change is still needed after ath12k add eMLSR hw mode 8 in > array ath12k_hw_mode_pri_map and enum wmi_host_hw_mode_config_type, > because more hw mode maybe added in next firmware/board data version > e.g hw mode 9, then it will also lead new array overflow without this > change. > > Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0-03427-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.15378.4 > > Signed-off-by: Wen Gong <quic_wgong@xxxxxxxxxxx> > Signed-off-by: Kalle Valo <quic_kvalo@xxxxxxxxxxx> Patch applied to ath-next branch of ath.git, thanks. 1e9b1363e2de wifi: ath12k: avoid array overflow of hw mode for preferred_hw_mode -- https://patchwork.kernel.org/project/linux-wireless/patch/20230714072405.28705-1-quic_wgong@xxxxxxxxxxx/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
