Wen Gong <quic_wgong@xxxxxxxxxxx> wrote: > Currently after the hardware restart triggered from the driver, the > station interface connection remains intact, since a disconnect > trigger is not sent to userspace. This can lead to a problem in > targets where the wifi mac sequence is added by the firmware. > > After the target restart, its wifi mac sequence number gets reset to > zero. Hence AP to which our device is connected will receive frames > with a wifi mac sequence number jump to the past, thereby resulting > in the AP dropping all these frames, until the frame arrives with a > wifi mac sequence number which AP was expecting. > > To avoid such frame drops, its better to trigger a station disconnect > upon target hardware restart which can be done with API > ieee80211_reconfig_disconnect exposed to mac80211. > > Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0-03427-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.15378.4 > > Signed-off-by: Wen Gong <quic_wgong@xxxxxxxxxxx> > Signed-off-by: Kalle Valo <quic_kvalo@xxxxxxxxxxx> This added a new warning: drivers/net/wireless/ath/ath12k/mac.c:6762: networking block comments don't use an empty /* line, use /* Comment... Please remember to run ath12k-check. I fixed this in the pending branch. -- https://patchwork.kernel.org/project/linux-wireless/patch/20230714092555.2018-1-quic_wgong@xxxxxxxxxxx/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches