Jeffrey Hugo <quic_jhugo@xxxxxxxxxxx> writes:
>> --- a/include/linux/mhi.h
>> +++ b/include/linux/mhi.h
>> @@ -299,6 +299,10 @@ struct mhi_controller_config {
>> * @iova_start: IOMMU starting address for data (required)
>> * @iova_stop: IOMMU stop address for data (required)
>> * @fw_image: Firmware image name for normal booting (optional)
>> + * @fw_data: Firmware image data content for normal booting, used only
>> + * if fw_image is NULL (optional)
>
> It looks like your implementation requires fbc_download to be set, and
> while you mention that for fw_sz, you don't mention it here. While I
> think this would be useful for non-fbc usecases, we don't have that
> use currently.
Thanks for the review. I submitted v4 to fix this.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
