Minjie Du <duminjie@xxxxxxxx> wrote: > 'phydir' returned from debugfs_create_dir() is checked against NULL. > As the debugfs API returns an error pointer, > the returned value can never be NULL. > > Therefore, as the documentation suggests that the check is unnecessary > and other debugfs calls have no operation in error cases, > it is advisable to completely eliminate the check. > > Signed-off-by: Minjie Du <duminjie@xxxxxxxx> > Reviewed-by: Jiri Slaby <jirislaby@xxxxxxxxxx> > Signed-off-by: Kalle Valo <quic_kvalo@xxxxxxxxxxx> Patch applied to ath-next branch of ath.git, thanks. f7eb8315b22a wifi: ath5k: remove phydir check from ath5k_debug_init_device() -- https://patchwork.kernel.org/project/linux-wireless/patch/20230714081619.2032-1-duminjie@xxxxxxxx/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
