> -----Original Message----- > From: Larry Finger <larry.finger@xxxxxxxxx> On Behalf Of Larry Finger > Sent: Tuesday, July 25, 2023 2:39 AM > To: Kalle Valo <kvalo@xxxxxxxxxx> > Cc: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>; linux-wireless@xxxxxxxxxxxxxxx; Larry Finger > <Larry.Finger@xxxxxxxxxxxx>; Ping-Ke Shih <pkshih@xxxxxxxxxxx>; Takashi Iwai <tiwai@xxxxxxx> > Subject: [PATCH] wifi: rtw89: Fix loading of compressed firmware > > When using compressed firmware, the early firmware load feature will fail. > In most cases, the only downside is that if a device has more than one > firmware version available, only the last one listed will be loaded. > In at least two cases, there is no firmware loaded, and the device fails > initialization. See https://github.com/lwfinger/rtw89/issues/259 and > https://bugzilla.opensuse.org/show_bug.cgi?id=1212808 for examples of > the failure. > Personally, I'm fine to avoid loading partial firmware, because of limitation of compressed firmware. What I care is driver probe time, so I measure the time 100 times and remove the highest/lowest 5% numbers, and then get the average probe time of 8852BE: Without this patch: 342,245,770ns With this patch: 346,473,726ns This patch increases about 4ms that can be acceptable. [...] > > Fixes: ffde7f3476a6 ("wifi: rtw89: add firmware format version to backward compatible with older drivers") > Cc: Ping-Ke Shih <pkshih@xxxxxxxxxxx> > Cc: Takashi Iwai <tiwai@xxxxxxx> > Signed-off-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx> Tested-and-acked-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>
