From: Yunsheng Lin <linyunsheng@xxxxxxxxxx> Date: Wed, 19 Jul 2023 20:13:37 +0800 > Split types and pure function declarations from page_pool.h > and add them in page_page_types.h, so that C sources can > include page_pool.h and headers should generally only include > page_pool_types.h as suggested by jakub. [...] > diff --git a/include/net/page_pool_types.h b/include/net/page_pool_types.h > new file mode 100644 > index 000000000000..9dc189082e20 > --- /dev/null > +++ b/include/net/page_pool_types.h > @@ -0,0 +1,193 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > + > +#ifndef _NET_PAGE_POOL_TYPES_H > +#define _NET_PAGE_POOL_TYPES_H > + > +#include <linux/ptr_ring.h> > +#include <linux/dma-direction.h> Nit: alphabetic sorting? > + > +#define PP_FLAG_DMA_MAP BIT(0) /* Should page_pool do the DMA > + * map/unmap > + */ > +#define PP_FLAG_DMA_SYNC_DEV BIT(1) /* If set all pages that the driver gets > + * from page_pool will be > + * DMA-synced-for-device according to > + * the length provided by the device > + * driver. > + * Please note DMA-sync-for-CPU is still > + * device driver responsibility > + */ [...] Thanks, Olek