Search Linux Wireless

Re: [PATCH] wcn36xx: remove space before ')'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/17/2023 12:04 AM, hanyu001@xxxxxxxxxx wrote:
Fixes checkpatch.pl error:

./drivers/net/wireless/ath/wcn36xx/dxe.c:470: ERROR: space prohibited before that close parenthesis ')' ./drivers/net/wireless/ath/wcn36xx/dxe.c:509: ERROR: space prohibited before that close parenthesis ')'

Signed-off-by: maqimei <2433033762@xxxxxx>

For all of your recent patches you have the issue that your Signed-off-by does not seem to be a legal name, and that it does not match the From address in your e-mail.

Refer to <https://www.kernel.org/doc/html/latest/process/submitting-patches.html?highlight=signed%20off#sign-your-work-the-developer-s-certificate-of-origin>

Also all wifi drivers should have a subject prefix of "wifi: <drivername>:", in this case "wifi: wcn36xx: "

The actual patch LGTM

---
  drivers/net/wireless/ath/wcn36xx/dxe.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/ath/wcn36xx/dxe.c b/drivers/net/wireless/ath/wcn36xx/dxe.c
index 9013f05..b8d7676 100644
--- a/drivers/net/wireless/ath/wcn36xx/dxe.c
+++ b/drivers/net/wireless/ath/wcn36xx/dxe.c
@@ -467,7 +467,7 @@ static irqreturn_t wcn36xx_irq_tx_complete(int irq, void *dev)
                         WCN36XX_DXE_0_INT_CLR,
                         WCN36XX_INT_MASK_CHAN_TX_H);

-        if (int_reason & WCN36XX_CH_STAT_INT_ERR_MASK ) {
+        if (int_reason & WCN36XX_CH_STAT_INT_ERR_MASK) {
              wcn36xx_dxe_write_register(wcn,
                             WCN36XX_DXE_0_INT_ERR_CLR,
                             WCN36XX_INT_MASK_CHAN_TX_H);
@@ -506,7 +506,7 @@ static irqreturn_t wcn36xx_irq_tx_complete(int irq, void *dev)
                         WCN36XX_DXE_0_INT_CLR,
                         WCN36XX_INT_MASK_CHAN_TX_L);

-        if (int_reason & WCN36XX_CH_STAT_INT_ERR_MASK ) {
+        if (int_reason & WCN36XX_CH_STAT_INT_ERR_MASK) {
              wcn36xx_dxe_write_register(wcn,
                             WCN36XX_DXE_0_INT_ERR_CLR,
                             WCN36XX_INT_MASK_CHAN_TX_L);




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux