Hi,
Yeah I'm home for this week, so really just a few more days.
I think it can wait, I'm not even sure there's a driver that fully supports S1G band upstream yet? Other than hwsim, but that doesn't _really_ matter. Well, arguably it's a whole new feature for S1G, so doesn't matter much anyway.
Also, I'd be a bit worried that the comment there means we didn't push the frequency offset through all the APIs, so it would still not work with the patch? Jun-Kyu, did you actually try this? If so, how?
But I haven't been able to take a closer look.
johannes
On 13 July 2023 02:37:24 CEST, Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
>On Tue, 11 Jul 2023 17:09:18 +0900 JUN-KYU SHIN wrote:
>> When channel_switch is performed to a channel with a freq_offset,
>> such as 909.5 MHz, channel_switch fails with the "-EOPNOTSUPP" error.
>> Since freq_offset is used in the S1G band, it should not be treated
>> as an error only with the freq_offset condition.
>>
>> Fixes: b6011960f392 ("mac80211: handle channel frequency offset")
>> Signed-off-by: JUN-KYU SHIN <jk.shin@xxxxxxxxxxxx>
>
>Johannes, since you seem to be around - yes/no/can wait? :)
>
--
Sent from my phone.
