On Wed, Nov 12, 2008 at 10:19:03AM -0800, Harvey Harrison wrote: > On Wed, 2008-11-12 at 13:02 -0500, John W. Linville wrote: > > On Wed, Nov 12, 2008 at 08:48:34AM -0800, Harvey Harrison wrote: > > > On Tue, 2008-11-11 at 16:51 -0500, John W. Linville wrote: > > > > These bits are shared already between ipw2x00 and hostap, and could > > > > probably be shared both more cleanly and with other drivers. This > > > > commit simply relocates the code to lib80211 and adjusts the drivers > > > > appropriately. > > > > > > > > Signed-off-by: John W. Linville <linville@xxxxxxxxxxxxx> > > > > --- > > > > > > Wouldn't it have been better to start from the mac80211 crypto bits > > > as lib80211 and modify hostap/ipw2x00 to use the 'new' lib80211 > > > crypto bits? > > > > I'm sorry, but you forgot to attach your patches... > > > > I will if it's desired, I just wanted to know if there was a particular > reason for going this way. Those bits are already shared between ieee80211 and the hostap driver. Unfortunately, they are not shared with a clean API. I don't think hacking on mac80211's crypto code is worthwhile until these drivers are given a bit more discipline in this area. IMHO, this is the better way to start. Perhaps you should find something more helpful to do instead. John -- John W. Linville Linux should be at the core linville@xxxxxxxxxxxxx of your literate lifestyle. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
