On Thu, 6 Jul 2023 at 13:39, Toke Høiland-Jørgensen <toke@xxxxxxx> wrote: > > Dongliang Mu <dzm91@xxxxxxxxxxx> writes: > > > Smatch reports: > > > > ath_pci_probe() warn: argument 4 to %lx specifier is cast from pointer > > ath_ahb_probe() warn: argument 4 to %lx specifier is cast from pointer > > > > Fix it by modifying %lx to %p in printk. > > > > Signed-off-by: Dongliang Mu <dzm91@xxxxxxxxxxx> > > Third time is the charm! :) > > Acked-by: Toke Høiland-Jørgensen <toke@xxxxxxx> But do we *want* to replace %lx with %p? Because this now causes a change in behavior, as the kernel will omit the pointer's address, while before it printed the actual memory address. Using %px would have kept the original behavior. So if the change is desired, it should be noted in the commit message. best Regards, Jonas
