Vivek Natarajan <vivek.natraj@xxxxxxxxx> writes: > Hello Kalle, Hello Vivek, > I have a few questions on the PS implementation. Here they are, > > 1) I see from your patch that power save is enabled whenever there > is no Tx for the specified 'timeout' period. Should we also take into > account the type of power connection( i.e battery or direct ac supply) > before enabling PS? That's a policy decision and should be in user space. User space can enable or disable the dynamic PS as it sees fit based on different parameters. > 2) Do you intend to leave the NULL frame formation [to the driver] Yes, that was my and Johannes' plan. > waking up the chip for TIM What do you mean by this? Sending a beacon interval setting to the chip? > and modifying sleep/awake time according to DTIM to the driver since > I did not see this in your TODO list? I think these should be in mac80211, just haven't thought that far yet. I'll add it to the TODO list. > ( I understand from the iwlwifi code that it just sends a request to > the firmware for sending NULL frame and the firmware takes care of > the rest. But it may not be so in the case of other vendor drivers.) Yes, that's how I have understood iwlwifi to work. Currently stlc45xx is the only hardware which requires the driver to create the null frames, but if we are more than one hardware I think we need to considering adding the feature to mac80211 (with a new HW flag, of course). > 3) Is the PS-POLL concept(or M frames in N milliseconds concept of Johannes) > > dropped after the DNS response timings related discussion that you had > since it might save some more power in low-traffic conditions? I have dropped it for now. I try to get a simple implementation approved first, we can add advanced stuff later. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
