On Wed, Jun 14, 2023 at 10:24 AM Kalle Valo <kvalo@xxxxxxxxxx> wrote: > > Azeem Shaikh <azeemshaikh38@xxxxxxxxx> writes: > > > strlcpy() reads the entire source buffer first. > > This read may exceed the destination size limit. > > This is both inefficient and can lead to linear read > > overflows if a source string is not NUL-terminated [1]. > > In an effort to remove strlcpy() completely [2], replace > > strlcpy() here with strscpy(). > > > > Direct replacement is safe here since WIPHY_ASSIGN is only used by > > TRACE macros and the return values are ignored. > > > > [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy > > [2] https://github.com/KSPP/linux/issues/89 > > > > Signed-off-by: Azeem Shaikh <azeemshaikh38@xxxxxxxxx> > > --- > > v1: https://lore.kernel.org/all/20230612232301.2572316-1-azeemshaikh38@xxxxxxxxx/ > > v2: https://lore.kernel.org/all/20230614134552.2108471-1-azeemshaikh38@xxxxxxxxx/ > > In the change log (after the "---" line) you should also describe what > changes you made, more info in the wiki below. In this case it's clear > as the patch is simple but please keep this in mind for future patches. > > No need to resend because of this. > Thanks Kalle. I did have the below line in my changelog. For future patches, do you mean that changelog descriptions need to be more specific than this? For example - updated title from "x" -> "y"? > Changes from v1 and v2 - updated patch title.
