Marek Vasut <marex@xxxxxxx> wrote:
> In case WoWlan was never configured during the operation of the system,
> the hw->wiphy->wowlan_config will be NULL. rsi_config_wowlan() checks
> whether wowlan_config is non-NULL and if it is not, then WARNs about it.
> The warning is valid, as during normal operation the rsi_config_wowlan()
> should only ever be called with non-NULL wowlan_config. In shutdown this
> rsi_config_wowlan() should only ever be called if WoWlan was configured
> before by the user.
>
> Add checks for non-NULL wowlan_config into the shutdown hook. While at it,
> check whether the wiphy is also non-NULL before accessing wowlan_config .
> Drop the single-use wowlan_config variable, just inline it into function
> call.
>
> Fixes: 16bbc3eb8372 ("rsi: fix null pointer dereference during rsi_shutdown()")
> Signed-off-by: Marek Vasut <marex@xxxxxxx>
> Reviewed-by: Simon Horman <simon.horman@xxxxxxxxxxxx>
Patch applied to wireless-next.git, thanks.
b241e260820b wifi: rsi: Do not configure WoWlan in shutdown hook if not enabled
--
https://patchwork.kernel.org/project/linux-wireless/patch/20230527222833.273741-1-marex@xxxxxxx/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
