Search Linux Wireless

Re: [PATCH] rtlwifi: rtl8188ee: mark RTX_POWER_{BEFORE,AFTER}_IQK_A reads as unused

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Ping-Ke Shih <pkshih@xxxxxxxxxxx>
Subject: Re: [PATCH] rtlwifi: rtl8188ee: mark RTX_POWER_{BEFORE,AFTER}_IQK_A reads as unused
From: Dmitry Antipov <dmantipov@xxxxxxxxx>
Date: Mon, 5 Jun 2023 12:43:23 +0300
Cc: "kvalo@xxxxxxxxxx" <kvalo@xxxxxxxxxx>, "linux-wireless@xxxxxxxxxxxxxxx" <linux-wireless@xxxxxxxxxxxxxxx>
In-reply-to: <dc499da404c21b1d2db71a792d7fb836bc9ef122.camel@realtek.com>
References: <b2198915-0e92-de99-d950-be46c2bd8e91@yandex.ru> <20230601105215.27013-1-dmantipov@yandex.ru> <3b92f9205003f44187f7ebf7add6c3e0626e9646.camel@realtek.com> <0d1f24b9-a058-52fd-b669-54aa4e9162f9@yandex.ru> <dc499da404c21b1d2db71a792d7fb836bc9ef122.camel@realtek.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0

On 6/2/23 09:13, Ping-Ke Shih wrote:

Don't you think casting of 'void' only makes tool happy?


The point is in commenting the pieces of code which looks like
leftovers and probably should be reconsidered. Explicit casts
to void should be considered as an extra annotations rather than
an attempts to fix something.

Dmitry

References:
- Re: [PATCH] rtlwifi: rtl8188ee: drop RTX_POWER_BEFORE_IQK_A and RTX_POWER_AFTER_IQK_A reads
  - From: Dmitry Antipov
- [PATCH] rtlwifi: rtl8188ee: mark RTX_POWER_{BEFORE,AFTER}_IQK_A reads as unused
  - From: Dmitry Antipov
- Re: [PATCH] rtlwifi: rtl8188ee: mark RTX_POWER_{BEFORE,AFTER}_IQK_A reads as unused
  - From: Ping-Ke Shih
- Re: [PATCH] rtlwifi: rtl8188ee: mark RTX_POWER_{BEFORE,AFTER}_IQK_A reads as unused
  - From: Dmitry Antipov
- Re: [PATCH] rtlwifi: rtl8188ee: mark RTX_POWER_{BEFORE,AFTER}_IQK_A reads as unused
  - From: Ping-Ke Shih

Prev by Date: Re: [PATCH v2 02/10] wifi: mt76: connac: add support for dsp firmware download
Next by Date: Re: [PATCH v3] MAINTAINERS: Add new maintainers to Redpine driver
Previous by thread: Re: [PATCH] rtlwifi: rtl8188ee: mark RTX_POWER_{BEFORE,AFTER}_IQK_A reads as unused
Next by thread: Re: [PATCH] rtlwifi: rtl8188ee: mark RTX_POWER_{BEFORE,AFTER}_IQK_A reads as unused
Index(es):
- Date
- Thread

[Index of Archives] [Linux Host AP] [ATH6KL] [Linux Wireless Personal Area Network] [Linux Bluetooth] [Wireless Regulations] [Linux Netdev] [Kernel Newbies] [Linux Kernel] [IDE] [Git] [Netfilter] [Bugtraq] [Yosemite Hiking] [MIPS Linux] [ARM Linux] [Linux RAID]