Neal Sidhwaney <nealsid@xxxxxxxxx> writes: > In some corner cases, an I/O read can fail and return -1, and this > patch detects this slightly earlier than is done today and logs an > appropriate message. > > Signed-off-by: Neal Sidhwaney <nealsid@xxxxxxxxx> The formatting seems to be correct now, at least patchwork looks ok: https://patchwork.kernel.org/project/linux-wireless/patch/20230601054034.43692-1-nealsid@xxxxxxxxx/ But the commit log should always answer to the question "why?". Is there a specific reason why you want to do it earlier? > @@ -980,6 +981,11 @@ static int brcmf_chip_recognition(struct brcmf_chip_priv *ci) > */ > regdata = ci->ops->read32(ci->ctx, > CORE_CC_REG(ci->pub.enum_base, chipid)); > + if (regdata == READ_FAILED) { > + brcmf_err("MMIO read failed: 0x%08x\n", regdata); > + return -ENODEV; > + } Indentation here does not look correct, did you run checkpatch? -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
