Search Linux Wireless

Re: [PATCH 1/3] wifi: rtw88: correct PS calculation for SUPPORTS_DYNAMIC_PS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ping-Ke Shih <pkshih@xxxxxxxxxxx> wrote:

> This driver relies on IEEE80211_CONF_PS of hw->conf.flags to turn off PS or
> turn on dynamic PS controlled by driver and firmware. Though this would be
> incorrect, it did work before because the flag is always recalculated until
> the commit 28977e790b5d ("wifi: mac80211: skip powersave recalc if driver SUPPORTS_DYNAMIC_PS")
> is introduced by kernel 5.20 to skip to recalculate IEEE80211_CONF_PS
> of hw->conf.flags if driver sets SUPPORTS_DYNAMIC_PS.
> 
> Correct this by doing recalculation while BSS_CHANGED_PS is changed and
> interface is added or removed. It is allowed to enter PS only if single
> one station vif is working. Without this fix, driver doesn't enter PS
> anymore that causes higher power consumption.
> 
> Fixes: bcde60e599fb ("rtw88: remove misleading module parameter rtw_fw_support_lps")
> Cc: stable@xxxxxxxxxxxxxxx # 6.1+
> Signed-off-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>

3 patches applied to wireless.git, thanks.

3918dd0177ee wifi: rtw88: correct PS calculation for SUPPORTS_DYNAMIC_PS
26a125f550a3 wifi: rtw89: correct PS calculation for SUPPORTS_DYNAMIC_PS
b408f33b35a4 wifi: rtw89: remove redundant check of entering LPS

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20230527082939.11206-2-pkshih@xxxxxxxxxxx/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux