Ping-Ke Shih <pkshih@xxxxxxxxxxx> writes: >> -----Original Message----- >> From: Dmitry Antipov <dmantipov@xxxxxxxxx> >> Sent: Thursday, June 1, 2023 12:24 PM >> To: Ping-Ke Shih <pkshih@xxxxxxxxxxx> >> Cc: Kalle Valo <kvalo@xxxxxxxxxx>; linux-wireless@xxxxxxxxxxxxxxx; >> Dmitry Antipov <dmantipov@xxxxxxxxx>; >> Dmitriy Antipov <Dmitriy.Antipov@xxxxxxxxxxxx> >> Subject: [PATCH] wifi: rtlwifi: remove unused timer and related code > > Should increase version number such as v2, v3, ... for newer one. And also always include a changelog, see the wiki link below for more. > Checkpatch warns this patch: > > ERROR: Missing Signed-off-by: line by nominal patch author > 'Dmitry Antipov <dmantipov@xxxxxxxxx>' Yeah, From and s-o-b need to always match. > Maybe, you can adjust your s-o-b to e-mail address of "From". It's also possible to add a second From field to the body of the message. Here's an example how I do it when I use kernel.org to submit my patches: https://patchwork.kernel.org/project/linux-wireless/patch/20230530141813.29333-3-kvalo@xxxxxxxxxx/ -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
