> -----Original Message----- > From: Dmitry Antipov <dmantipov@xxxxxxxxx> > Sent: Wednesday, May 31, 2023 1:51 PM > To: Ping-Ke Shih <pkshih@xxxxxxxxxxx>; Larry Finger <Larry.Finger@xxxxxxxxxxxx> > Cc: Kalle Valo <kvalo@xxxxxxxxxx>; linux-wireless@xxxxxxxxxxxxxxx; lvc-project@xxxxxxxxxxxxxxxx; Dmitriy > Antipov <Dmitriy.Antipov@xxxxxxxxxxxx> > Subject: Re: [PATCH] rtlwifi: rtl8188ee: drop RTX_POWER_BEFORE_IQK_A and RTX_POWER_AFTER_IQK_A reads > > 3. In general, is it always (or just sometimes) required to read (some > subset of?) BB registers even if we don't interested in their values? > Is it explicitly required by the hardware design? > I think it isn't always required basically. However, for this case, I can't find the author to know if we can remove the statements. There is a delay to make sure these read operations can get correct values, so I suggest to have similar changes like 6c75eab0417b9e5b05a18dbfc373e27a8ef876d8 you mentioned if we really want this patch. Ping-Ke
