On Fri, 2008-11-07 at 10:07 -0800, Harvey Harrison wrote: > On Fri, 2008-11-07 at 09:58 -0800, Reinette Chatre wrote: > > From: Kolekar, Abhijeet <abhijeet.kolekar@xxxxxxxxx> > > > > Patch fixes sparse warnings. No need to convert u8 variable > > to 32. > > > > Signed-off-by: Abhijeet Kolekar <abhijeet.kolekar@xxxxxxxxx> > > Signed-off-by: Reinette Chatre <reinette.chatre@xxxxxxxxx> > > --- > > It's customary to put the actual sparse warnings being fixed in the > commit message. sorry - will do next time. > In this case I assume it was this: > > drivers/net/wireless/iwlwifi/iwl3945-base.c:4838:18: warning: invalid assignment: |= > drivers/net/wireless/iwlwifi/iwl3945-base.c:4838:18: left side has type unsigned char > drivers/net/wireless/iwlwifi/iwl3945-base.c:4838:18: right side has type restricted __le32 yes ... this is the warning being fixed. Thanks for the review Reinette -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
